Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1987
This is Ready to Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jayantpatil1234 commented on the issue:
https://github.com/apache/cloudstack/pull/1987
I have tested this and **LGTM** for test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1987
@niteshsarda thank you very much :)
The less duplicated or useless code around the better.
The method 'updateDomain' is huge and you just changed a single line there,
so I
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1987
@rafaelweingartner : As per your suggestion, I have changed the search
query and also removed the unused method updateDomain from
managementserviceimpl class.
Please check.
---
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1987
@niteshsarda I suggest you adding line 2281 from "managementService" to
"domainMgr". The only difference between those two methods is this line.
Assuming that you changed the method
