[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1994 Thank you all. I will merge #1961 and #1994 now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 @karuturi Travis is now failing as it doesn't find key "nfs2" 2017-03-24 17:33:45,621 - CRITICAL - EXCEPTION: test_03_migration_options_storage_tags: ['Traceback (most recent call

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 @karuturi I refactored last marvin test which was failing on Travis. These are results in our env: [root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//4GSNSY/results.txt

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 Thanks @mike-tutkowski! I pushed force to kick off Travis again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1994 OK, this LGTM (as long as Travis shows green before we merge). Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1994 I should have a chance to look through this later tonight. In the meanwhile, perhaps we can re-push the code to kick off Travis again (since its most recent run has a failure). Thanks!

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski can you do a final review please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 Thanks @serg38, we are using `mgtSvr` details provided in .cfg file, should we use these for Marvin too? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Looks like Travis cant SSH into management server during the test . 2017-03-17 19:26:58,672 - DEBUG - mount -t nfs nfs:/export/automation/1/testprimary

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1994 Thanks @nvazquez Waiting for LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 @karuturi I added marvin tests to simulate tests performed by @mike-tutkowski. This are results in our env: [root@ussarlabcsmgt41 cloudstack]# cat

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 Hi @karuturi, I've been working on marvin tests, I hope posting them today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez any update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 @rafaelweingartner I pushed changes and squashed my commits as it could be easier to review. I also added unit tests for new methods --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski awesome, thanks for testing this PR! @rafaelweingartner thanks for reviewing, I'll work on changes proposed @karuturi sure, I'll work on it, thanks! --- If

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez I think any of the existing marvin tests didnt catch this bug. Is it possible to add a marvin test for it? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1994 I have run the following use cases successfully: PS = Primary Storage ST = Storage Tag CO = Compute Offering DO = Disk Offering V = Volume Create PS_1

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1994 I should be able to do so over the weekend. On Mar 10, 2017, at 11:26 AM, serg38 > wrote:

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski Can you test this fix in your environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 Trillian test result (tid-946) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28653 seconds Marvin logs:

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1994 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-585 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1994 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @rhtyd @borisstoyanov Can you kick off new tests for this release blocker? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 @serg38 actually is not being used anymore, I'll add removalof the view on last commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Is storage_tag_view still in use after this change that reference old way of retrieving the tags? If not should we remove it? E.g. host tags don't have a separate view. --- If your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1994 Hi @rafaelweingartner, you're right, it was basically that fix. I've pushed another commit due to issue reported by @mike-tutkowski in mailing list: I have an NFS SR as primary

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez I am assuming the change needed to fix the bug is line 135 at PrimaryDataStoreHelper.java? The other changes are regarding code conformity --- If your project is set

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 Trillian test result (tid-940) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28984 seconds Marvin logs:

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1994 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1994 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1994 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Should we simply replace storage_tag_view instead of switching queries over to another view? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski @karuturi @koushik-das @rafaelweingartner Please review the fix for 4.10 blocker --- If your project is set up for it, you can reply to this email and have your reply appear on