Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
In the travis ci the tests are failing it could be because of timeout. But
when I run some of the test locally it is passing.
The same test test_invalid_gw_nm is failing in travis
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
@koushik-das I have updated for your review comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1996
@jayapalu can you push -f to kick Travis?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
It seems there is issue in CI due to that test are failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1996
@rhtyd Once this PR got the LGTMs, I can rebase it on 4.9. Can you please
review this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1996
@jayapalu this is a useful security fix for 4.9 as well, can you please
rebase against the 4.9 branch and edit the base branch of the PR to 4.9?
---
If your project is set up for it, you can