Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/672
@anshul1886 yes given you've created a new PR, you may close this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/672
@rhtyd @karuturi Should I close this PR then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/672
@rhtyd @karuturi @syed Raised #1941 against 4.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/672
Thanks @anshul1886 kindly also squash your changes and fix the commit
message/jira id etc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/672
Resolving conflicts and rebasing the PR against 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/672
@anshul1886 I would suggest, if your PR already has @syed 's fix along with
other useful fixes -- please rebase against 4.9, fix the conflicts and we can
help review/test your PR if you've
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/672
@karuturi @rhtyd @syed PR #1829 is subset of this PR i.e. that contains
the same fix as one commit of this PR. How to proceed with that?
---
If your project is set up for it, you can reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/672
@anshul1886 can you retarget this PR for 4.9? Also rebase against 4.9, fix
conflicts thanks. /cc @karuturi @syed @koushik-das
---
If your project is set up for it, you can reply to this email
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/672
@jburwell those are fixing different bugs but all all needed to enable this
that's why they are kept as separate tickets.
---
If your project is set up for it, you can reply to this email
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/672
@anshul1886 could please squash the three commits and add the ticket
reference to the commit message?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/672
### ACS CI BVT Run
**Sumarry:**
Build Number 133
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder (search
11 matches
Mail list logo