Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/977
great effort from everyone in terms of code, testing and discussion.
Overall, all the comments are addressed and has test runs. I am merging this
now.
---
If your project is set up for it,
] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM
Snapshotting implementatio...
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/977
hey @kiwiflyer (not related to the PR at hand) I see that this PR is not
reported on acspr.enu.net as ci complete
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/977
hey @kiwiflyer (not related to the PR at hand) I see that this PR is not
reported on acspr.enu.net as ci complete. Is that a bug?
---
If your project is set up for it, you can reply to
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
@karuturi please see testing above. This PR now has working tests and is
ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
Great job all. I think this one is ready.
@ustcweizhou @nathanejohnson
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/977
@nathanejohnson I rebased my branch with latest master, and apply your
commit.
now this PR should have same code with vm-snapshot branch under your
account.
---
If your project is set
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou for what it's worth, our branch / fork has all changes from
master incorporated
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou I just now squashed the commits, but the branch @leprechau
mentioned above is the branch I was working on that incorporates that commit
plus a few others.
Thanks
Github user leprechau commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou Nathan's work can be found in the `vm-snapshot` branch of our
fork here: https://github.com/myENA/cloudstack/commits/vm-snapshot
---
If your project is set up for it, you can
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/977
@nathanejohnson do you mean the commit 7a2a1c1 ? I can add it into this PR
so you do not need to open a new PR.
---
If your project is set up for it, you can reply to this email and have
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou @kiwiflyer I was finally able to get an environment to run
tests. So far I have reworked smoke/test_vm_snapshots.py with @kiwiflyer so
that it handles the chnages from this
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou @nathanejohnson
https://github.com/myENA/cloudstack/commit/7a2a1c1c432dd2e39065627eed38bd3fb429cf70
Nathan is going to test this for us.
---
If your project is set
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou I'm working on fixing the tests. In regards to item 3, Is
there actually an API call for this, rather that it just being on a timer
thread? Maybe I'm blind, but I'm not seeing
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/977
@kiwiflyer indeed, we need make some changes in
./test/integration/smoke/test_vm_snapshots.py
1.
'''
vm_snapshot = VmSnapshot.create(
self.apiclient,
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou @rhtyd
So the vmsnapshot test seems might need some work. Here's the exception it
threw:
2017-01-10 17:27:01,025 - CRITICAL - EXCEPTION:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
Trillian test result (tid-773)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38115 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
Packaging result: âcentos6 âcentos7 âdebian. JID-450
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou we can work on the db schema paths soon; assuming 4.9.3.0
won't bring in any db changes; we may not change the file names.
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/977
squashed and rebased with latest master.
However, this commit still changes the setup/db/db/schema-4920to41000.sql,
not schema-4930to41000.sql which does not exist. @rhtyd
---
If your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou can you squash your changes, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/977
added a commit to enable the smoke test test_vm_snapshots.py on KVM.
thanks @serg38
@rhtyd could you please test it again?
---
If your project is set up for it, you can reply to
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
Trillian test result (tid-772)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48642 seconds
Marvin logs:
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/977
@rhtyd @ustcweizhou We need to enable smoke tests for vmsnaphsots for KVM
in test_vm_snapshots.py
if cls.hypervisor.lower() in (KVM.lower(), "hyperv", "lxc"):
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
Packaging result: âcentos6 âcentos7 âdebian. JID-449
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/977
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/977
squashed. no code change compared with last commit.
git diff 9d4d2683ff7eaed27e15e7db91aadcba05736cc8
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
Thanks @ustcweizhou please also meld them into a single commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/977
changed the title of commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou @kiwiflyer please squash your changes, use the jira id in the
commit summary etc first.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
Based on functional testing LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
VM Snapshot revert was successful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
VM snapshot revert live:
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
VMsnapshot was successful with running VM as seen above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/977
---
If your project is set up for it, you can reply to this email and have
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/977
As an update, I've been battling technical difficulties getting my bubble
environment back operational again, and I am about to go out of town for a bit
so I have not had a chance to
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/977
@ustcweizhou I'm pulling this down for testing, I will update with logs and
screen shots soon
---
If your project is set up for it, you can reply to this email and have your
reply appear
45 matches
Mail list logo
