Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1024#issuecomment-153477674
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1024#issuecomment-153374008
code looks good to me too. what happened to the policy of not accepting
anything without test?
---
If your project is set up for it, you can reply to this ema
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1024#issuecomment-153371665
:+1: (code review only) good improvement.
A test case would have been nice.
---
If your project is set up for it, you can reply to this email and have your
re
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1024#issuecomment-153351476
Thanks @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1024#issuecomment-153341635
Result before this PR:
```
root@s-58-VM:~# ifconfig
eth0 Link encap:Ethernet HWaddr 0e:00:a9:fe:03:b0
inet addr:169.254.3.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1024#issuecomment-153311038
Seems like a good fix to me. Can't test it manually at this moment though
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1024#issuecomment-153286419
Thanks @bhaisaab nice fix, have seen it before. Will run some tests soon.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1024
[4.6/master] CLOUDSTACK-9019: Add storage network offering in ssvm only if
storageâ¦
⦠network is defined
During creation of SSVM, checks and adds
NetworkOffering.SystemStorageNet
