Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1380
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1380#issuecomment-180483422
Since this is again maven related changes, will close this PR and move the
commit to https://github.com/apache/cloudstack/pull/1397 's branch
---
If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1380#issuecomment-176781714
great LGTM. It is only removing an unused dep from the pom.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1380#issuecomment-176780479
@DaanHoogland env issue seems, had to include a new test scope dependency
to fix it.
---
If your project is set up for it, you can reply to this email and have yo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1380#issuecomment-176645627
loks good but now jenkins complains about these:
GetServiceProviderMetaDataCmdTest.testAuthenticate:96 » NoClassDefFound
org/w3...
SAML2LoginAPIAut
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1380#issuecomment-176291448
@DaanHoogland upgraded my local 4.7.0 cloudstack to 4.7.1 without the
spring-saml ext dependency and logged in as a SAML user. Log:
2016-01-28 18:16:32,085
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1380#issuecomment-176170704
@DaanHoogland sure. There are no imports (git grep
org.springframework.security to check) from any part of the codebase and since
I had put it in I know for sure i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1380#issuecomment-176157606
looks good but needs testing, right? might be a runtime issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
