[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

2015-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/991 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/991#issuecomment-151940210 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/991#issuecomment-151784718 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

2015-10-27 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/991 [master/4.6] CLOUDSTACK-8999: Don't override resource if provided by agent.properties If a custom resource (kvm/libvirt implementation) is defined in agent.properties don't override with t