Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221863141
this one just does not want to turn green. :( wanna give it another shot
@rhtyd?
---
If your project is set up for it, you can reply to this email and have your
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1511
4.9/master bountycastle changes
This PR adds bountycastle related version and code fixes from @DaanHoogland
on top of https://github.com/apache/cloudstack/pull/1510
I could not fix
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221220936
rebase, yes. I will keep reformat and functional/technical changes
segragated, however.
funny enough the .../push run is started again this time around
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221215124
@DaanHoogland I don't know, can you rebase and squash push -f?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221205073
timeouts in the before_script.sh again but I will investigate locally.
@rhtyd do you know why only continuous-integration/travis-ci/pr was run
this time
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221190865
tnx @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221189095
Done @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1511
4.9/master bountycastle changes
This PR adds bountycastle related version and code fixes from @DaanHoogland
on top of https://github.com/apache/cloudstack/pull/1510
I could not fix
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221186203
@rhtyd please re-open this one, if you will.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221159200
@DaanHoogland can you rebase and push again to try to kick off Travis and
see if we can clear this one up? Thanks...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221159015
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 1
Duration: 4h 20m 05s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220640589
Ok. Travis has been pretty consistently green for PRs recently, so I have
not seen this problem elsewhere. I am not sure why there are sometimes more
than once
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220637398
@swill please see my comment above about the travis failures. BTW why is
there sometimes two travis runs (pr and push) and sometimes only one?
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220624878
I have seen similar issues in a couple other PRs. Since this is a PR
related to connectivity, I do want to try to get a cleaner CI run if I can.
Also, travis is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220595800
Im not sure what to think of those failures. I will run again in clean
setup to see if I can get rid of those.
---
If your project is set up for it, you can reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220595610
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 4h 21m 39s
```
**Summary of the
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r64015658
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -429,60 +434,42 @@ private void validateChain(List chain,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220529332
theare is two timeouts in the before script again and one exception in a
teardown method of a test.
@swill, are these errors repetible as well? they seem
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220433360
@swill I must have made a booboo spliting the style parts from the test
upgrades. I will look at it over the weekend.
---
If your project is set up for it,
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-220431955
This is failing to build for me.
```
Running org.apache.cloudstack.affinity.AffinityApiUnitTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63852079
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -429,60 +434,42 @@ private void validateChain(List chain,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63851517
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63851057
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63829633
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -429,60 +434,42 @@ private void validateChain(List chain,
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63828871
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63688438
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63683861
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219993865
@swill the GLB code missing is false alarm. I had removed unused code
months ago to get rid of warnings. I am compiling a version without pedantic
formatting
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219973474
tag:needslove
@swill Looking into @koushik-das remarks I noticed global loadbalancing
code different in this one compared to the previous merge commit!
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219971607
@koushik-das most significantly around line 690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219971144
@koushik-das I will look at those two comment, thanks
and no, quite significant changes were done in the NetscalerResource. You
are right that a lot of
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219945994
@DaanHoogland Not able to see diffs for NetscalerResource.java, are the
changes mostly related to adding 'final' keyword? Provided some comments, rest
of the
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63655432
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1511#discussion_r63655061
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -341,179 +350,172 @@ public SslCertResponse
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219088252
This one is coming back with a clean bill of health. I think we are ready
on this one. Can I get some code review? Thanks...
---
If your project is set up for
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219088009
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 9h 21m 07s
```
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218714480
@rhtyd the issue seems to occur in the prepare script not in the tests:
./tools/travis/before_script.sh
---
If your project is set up for it, you can reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218713732
@DaanHoogland there is a known issue in test_list_ids_parameter test
causing issue. You can force travis by doing a pull --rebase and/or git commit
--amend and then
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218712059
@swill, I have to correct myself. The timeout is in the before_script.sh.
This is run several times without problems and then fails in a test set.
In the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218699576
@rhtyd thanks, looks like @swill is right and this needs more tlc.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218656345
@DaanHoogland done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1511
4.9/master bountycastle changes
This PR adds bountycastle related version and code fixes from @DaanHoogland
on top of https://github.com/apache/cloudstack/pull/1510
I could not fix
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218542671
Good point, I am numb to travis timeouts. RM work remnance :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218503116
@DaanHoogland well a timeout in combination with a connection is not being
able to be established seems relevant since it is related to the code that has
changed.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218473575
a timeout @swill. in travis that is not a good indication of not working. I
wouldn't know where to look. @rhtyd can you close and reopen?
---
If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218458113
the travis logs seem to indicate that something is not working...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218411583
I've rebased against latest master and pushed -f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-216305206
@DaanHoogland please rebase and push -f again, to re-kickoff Travis; I'll
review and test this change soon against a real KVM env tomorrow
---
If your project is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-216287103
I need some code reviews on this one. Also, @DaanHoogland you may have to
push again. Our lovely checkers are being annoying again...
---
If your project is set
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-216229542
@DaanHoogland please rebase against latest master; after that I can help
test this in my env. Thanks.
tag:needlove
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214463216
Just finished all reruns of failing tests in the bubble. They all succeeded.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214459138
Thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214458410
I found one bug and added a commit to solve it. I will keep at tjis one for
a while.
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214455195
Lets get some CI results in here so we can start to figure out what is
going on. I believe I had a bunch of problems with this PR before it was
broken out, so I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214454225
@swill it seems the berfore script is failing sometimes. I don't think this
is a problem with the PR itself.
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-21297
I will run those failed travis tests in the bubble. I am seeing some
failures as well so this needs more work
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214414511
Thanks @DaanHoogland. Travis seems to be upset with a couple errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214297629
@swill I started the smoke tests for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214249307
@DaanHoogland thanks, if we can migrate to Java8 I won't mind not fixing
the issue for 1.7 at all
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-214243282
@rhtyd I am using 1.8 exclusively atm. I will see if I find any problems in
that. may look at 1.7 someday.
---
If your project is set up for it, you can
63 matches
Mail list logo
