Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/650
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-130988339
Added a unit test for SAML2AuthManager, will merge after Travis goes green
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-130972448
Discussed the PR
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-130971943
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-130219642
open for review, tests added; cc @abhinandanprateek @remibergsma
@wilderrodrigues @karuturi
---
If your project is set up for it, you can reply to this email and
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36737719
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ public St
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36712694
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ public St
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36621580
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ publi
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/650#discussion_r36621140
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java
---
@@ -322,21 +306,11 @@ public St
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-129041564
@bhaisaab OK, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-129041037
@remibergsma yes, that's the aim to get them in both 4.5/master and have
them in 4.5.2, 4.6.0+; these changes try to fill in deficiencies in the saml
implementation
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-129040266
@bhaisaab Will this also land in master once it's in 4.5?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127484976
Integration test will be tricky as it does http redirections etc, will add
unit test
---
If your project is set up for it, you can reply to this email and have you
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127482730
New api cmd and other changes. can you add unit/marvin tests please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127478102
any LGTM please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127383237
Travis fixed in https://github.com/apache/cloudstack/pull/652
Will kick again once PR #652 is merged on 4.5
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127350489
@bhaisaab @DaanHoogland had a look at this..
Codehaus shut down only recently, in July. On the site they say:
If your configuration is not updated and
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127288807
@bhaisaab I know of no fix. I had a quick look and recognised codehaus in
the error, remembering that They shut down. For some reason it seems not to be
a probl
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127285144
@DaanHoogland thanks, looks like it. In that case, did we fix this on
master? If so, we can possible port the fix to 4.5/4.4/4.3?
---
If your project is set up for
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127281959
@bhaisaab org.codehaus.plexus.classworlds.launcher.Launcher I don't know
the details but codehaus has abandonned their opensource repo support. Form
their main
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/650#issuecomment-127265742
@DaanHoogland @wilderrodrigues @karuturi @kishankavala @abhinandanprateek -
any ideas why Travis is failing on 4.5 (in general), also please help review.
---
If yo
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/650
APIServlet, AuthCmd, SAML fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cloudstack 4.5-samlfixes
Alternatively you can revi
22 matches
Mail list logo
