[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-07 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1162#issuecomment-162644589 LGTM: Old default behaviour is to enable service: ``` [root@cs1 x86_64]# cloudstack-setup-management --tomcat7 Starting to configure CloudSt

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1162#issuecomment-162342893 @DaanHoogland That makes no sense. We should build RPMs and install mgt server from it and test both the new and existing features. The integration tests do not

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1162#issuecomment-162341391 lgtm @remibergsma can you schedule a regression? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-04 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46672120 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServi

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671989 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServ

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671886 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServ

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-04 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671835 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServi

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-04 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46671185 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServi

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-04 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46670911 --- Diff: python/lib/cloudutils/serviceConfigServer.py --- @@ -135,9 +135,14 @@ def checkHostName(): self.syscfg.svo.disableServ

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-04 Thread ProjectMoon
Github user ProjectMoon commented on the pull request: https://github.com/apache/cloudstack/pull/1162#issuecomment-161926917 Removed the unintentional change to the initLoging (sic) method. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-03 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46618985 --- Diff: client/bindir/cloud-setup-management.in --- @@ -24,20 +24,23 @@ from cloudutils.globalEnv import globalEnv from cloudutils.serviceConfi

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-03 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1162#discussion_r46613321 --- Diff: client/bindir/cloud-setup-management.in --- @@ -24,20 +24,23 @@ from cloudutils.globalEnv import globalEnv from cloudutils.serviceConf

[GitHub] cloudstack pull request: Add support for not (re)starting server a...

2015-12-03 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request: https://github.com/apache/cloudstack/pull/1162 Add support for not (re)starting server after cloud-setup-management. This adds an option to the cloud-setup-management script to not start the management server after a successful confi