[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1428 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-09 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217887345 I think this one is ready. The failures are things that periodically fail in my environment and are unrelated to this code. Thanks... --- If your project is set up

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-08 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217771948 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 2 Errors: 0 Duration: 9h 09m 47s ``` **Summary of the p

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217513880 Ok, I will get CI run against this one to make sure that nothing else is broken. This is ready pending the CI run... --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-06 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217507957 LGTM (code review only) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-06 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217482136 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-05 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217341007 @Slair1 perfect, thanks for confirming. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-05 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217338822 @swill it is confirmation the code worked for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-05 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217322125 @Slair1 is that confirmation that this code worked for you? It is a bit unclear what you were communicating. Thx. --- If your project is set up for it, you can rep

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-05 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217321289 I ran this in our lab and tested the failover and works as expected. LGTM --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-02 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-216396939 @kiwiflyer and @rhtyd I've been troubleshooting the proxy issue and it was an issue in my environment! i have things worked out and everything works fine. --- I

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-216224800 tag:needlove --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215860378 Interesting. I'll go digging into the code. I'm not that familiar with the console proxy (yet). --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215859262 @kiwiflyer No, we were not failing over our ACS mgmt servers. We still had both up and functional and were able to log directly into both (and of course through our

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215856646 @Slair1 Are you failing a ACS management server in addition to the MySQL instance? If so, make sure your Load Balancer is also moving the traffic to the backu

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215854412 this LGTM. we have been running this in our environment for over a month (ACS 4.8). This PR fixes the issue we had with cloudstack-mangaement not starting when sql

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-04-29 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-215840702 @Slair1 @dmabry @remibergsma Could I get some review on this when you get a chance? I'd like to get this PR moving. --- If your project is set up for i

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-10 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-195054079 Looks like the cloudstack-usage server has a similar problem. it continuously restarts if db.ha.enable = true. i got it to work in my environment with the c

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-08 Thread Slair1
Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-194096939 Thanks guys, FYI i applied these change to my 4.8 source, running on Centos7 and it fixed the problem for me also. Thanks again!! --- If your project is set up for

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-07 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-193485886 @remibergsma In reference to other releases, yes this might also be broken on Ubuntu. We don't use Ubuntu, so having someone chime in who can test this would be n

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-07 Thread dmabry
Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-193407327 @remibergsma , We loaded up the management server with this patch and it appears to work just fine on 4.7.1 with db.ha.enable=false and db.cloud.slaves left blank.

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-07 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-193404245 Hi Remi, Yes, we tested it with HA disabled. David is going to upload the logs for reference. The mysql-connector is also referenced in the ca

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-07 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-193383891 Hi @kiwiflyer, did you test this without MySQL HA as well? I doubt it will work without `mysql-connector-java`. Also, this most likely also needs to be fixed on

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-192913387 Daan, Sorry about that. I've fixed it, pushed the commit and checks are now passing. - Simon --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-04 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-192309041 I've manually tested this on 4.7.1 and also on master. Prior to the patch, the following exception was thrown: 016-03-03 12:00:13,204 INFO [c.c.

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-04 Thread kiwiflyer
GitHub user kiwiflyer opened a pull request: https://github.com/apache/cloudstack/pull/1428 Addresses CLOUDSTACK-9300 where the MySQL HA StaticStrategy class fai… You can merge this pull request into a Git repository by running: $ git pull https://github.com/myENA/cloudstack