[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...

2016-01-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1315 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...

2016-01-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1315#issuecomment-170338260 LGTM too, thanks @shwetaag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...

2016-01-08 Thread shwetaag
Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/1315#issuecomment-169947496 @DaanHoogland I did the code review by code walk through and the code looks good to me --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...

2016-01-07 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1315#issuecomment-169611566 looks good on first sight, buiding an env to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...

2016-01-06 Thread pavanb018
GitHub user pavanb018 opened a pull request: https://github.com/apache/cloudstack/pull/1315 Automation for CLOUDSTACK-9214 , detect wrong GW or NM Automation for CLOUDSTACK-9214 This script automates the validation of network address or broadcast address given for gateway