Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-110148582
Hi @bhaisaab :)
The new https://github.com/apache/cloudstack/pull/372 was built on top of
this one, so all the fixes in this are also in the other one.
I
Github user rsafonseca closed the pull request at:
https://github.com/apache/cloudstack/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-110141856
@rsafonseca hey, looks like the new #372 one some interesting things (such
as embedded jetty); do you want to or have already take the good stuff from
this PR to
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-110082001
This has been stale for a while, here's something to spice it up :)
https://github.com/apache/cloudstack/pull/372
If all in agreement will close
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-106741425
Hi @remibergsma
First of all. thank you for your comment :)
I've been very busy these past couple of days, so i haven't gotten around
to do what you
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-106743307
Hi @rsafonseca
I got your PR to build the RPMs and do some manual tests on it.
RPMs were created successfully! I then copied them into a
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-106752449
Hi @wilderrodrigues
Both the issues you hit are legacy behaviour :)
I'm guessing that you've deployed it in debian, because the server.xml
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-106758023
Indeed.. it's only setup on centos 6 and not 7, sorry for misleading you
there :)
cloudstack-setup-management will link the server.xml in any environment
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-106760113
Hi @rsafonseca
I executed the script then...
lrwxrwxrwx. 1 root root 44 May 29 05:39 server.xml -
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r31114895
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtConsoleProxyLoadCommandWrapper.java
---
@@ -49,6 +49,11
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-105857189
Hi @rsafonseca
Cool answer as the PR is hanging for way too long. :)
I will apply the changes to a separate branch and create a PR.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-10584
Hi @wilderrodrigues
I was hoping on reducing the number of changes from this PR to master, so
it would be better if you pushed it along with your refactor
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-105935950
Hi @rsafonseca,
It's clear that this was quite some work to pull off, so first of all:
thanks! To be honest, I'm not sure on how to test this properly
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r31043937
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtConsoleProxyLoadCommandWrapper.java
---
@@ -49,6 +49,11 @@
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-105247153
@rsafonseca Thanks for updating the PR. I think a rebase is needed. I see a
lot of rc/init files removed esp from centos7, fedora20/21 directories? Also,
have you
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-105057113
looks like a couple more things got broken since last rebase with master...
need to refix :|
---
If your project is set up for it, you can reply to this email
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-103820696
Hello @wilderrodrigues :)
I guess the status of this PR is that it was waiting for me to fix the
build issues... i was away since last wednesday and just got
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-103450261
Hey @rsafonseca,
Thanks for improving ACS! ;)
What is the status of this PR? I noticed that the last build failed, but it
doesn't seem
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30591946
--- Diff: packaging/package.sh ---
@@ -48,6 +48,13 @@ function packaging() {
fi
DISTRO=$3
+
+JDK=$(rpm -qa | grep
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30316856
--- Diff: packaging/package.sh ---
@@ -48,6 +48,13 @@ function packaging() {
fi
DISTRO=$3
+
+JDK=$(rpm -qa | grep
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-101670968
@rsafonseca sorry, the PR fails to cleanly apply on master. Can you rebase
against master and send it again, along with any other fixes. Thanks.
---
If your
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30232177
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30233372
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-101683092
@bhaisaab rebased and sent. No new fixes since yesterday, but i rolled back
the change of port 9090, to not leave anyone unhappy and make things easier on
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-101825246
Getting this:
[root@jenkins packaging]# bash package.sh -d centos63
-d centos63 --
7
java-1.x.0-jdk-devel 1.7.0+ not found\n Cannot retrieve
Github user terbolous commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30280222
--- Diff: packaging/package.sh ---
@@ -48,6 +48,13 @@ function packaging() {
fi
DISTRO=$3
+
+JDK=$(rpm -qa | grep
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30165536
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30168912
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30166628
--- Diff: client/pom.xml ---
@@ -384,23 +408,6 @@
/executions
/plugin
plugin
-
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-101387790
Rafael, the gzip compression *alone* indeed does not make the tomcat serve
it compressed
* tomcat 8.0 allows [configuring the default
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30169643
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
should I force dynamic compression or not, does not mean that creating a
duplicate file with .gz extension will make it serve compressed :)
All that this was doing was duplicating content (both files compressed and
uncompressed were being shipped) and installed, but only the uncompressed
version
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-101399140
Good catch k0kza, I hadn't noticed that StaticResourceServlet class, but
i'll do some benchmarking on that vs tomcat 8's connector built in compression
features,
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30165996
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30173402
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
I have no IE righ here, but the 'never' setting seems to be a problem. I
would love to see it going away but if that creates bugreports or confusion
for users then it is no fun. Would you agree in having that 'now' thing only
for IE for safety?
Here you go:
I would agree to having that for safety in IE if it wasn't hurting the
other browsers so much.
I'd do some testing to find out exactly if there is an issue and if
reproducible, find a different workaround.. this just isn't worth the time
waiting for reply from everyone else...
Carlos suggested a
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/238#discussion_r30176487
--- Diff: ui/index.jsp ---
@@ -1761,73 +1761,73 @@
!-- jquery.tokeninput.js --
script src=lib/jquery.tokeninput.js
Nice! I will bookmark this site...
No KVM? :-)
On Tue, May 12, 2015 at 10:47 PM, Carlos Reátegui create...@gmail.com
wrote:
I have no IE righ here, but the 'never' setting seems to be a
problem. I would love to see it going away but if that creates bugreports
or confusion for users then
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-101235698
@rsafonseca thanks for the updated PR, really like the last update to bring
down the mgmt package size. Unfortunately I'm caught up with dayjob and since
it's a
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-101265715
Hi @bhaisaab :)
I've also made some basic testing with fedora 2x as you asked and got
everything working last night (apart from having the cluster servlet
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-100966791
Hi @bhaisaab
Have you had time to test this? I'm amazed no one else cared to take a look
at it, as it's a big change and a big step into supporting java8 and
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-100262595
Looks good, I see you've remove tomcat requirement as a package dependency.
Is this embedding tomcat so we won't need to install on the distro? I can help
test it
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-100282638
Yes, it completely removes the need to have tomcat installed in the distro,
and at the same time won't conflict if there is any other version of tomcat
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-100315706
Thanks @rsafonseca, it sounds great. While I think I had removed awsapi
related tomcat stuff with commit 58999da it's possible I may have missed few
spots, or a
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/238#issuecomment-100317657
Yes, I'll take care of that.. i just haven't removed the old tomcat files
of other installers so that this PR wouldn't break building on any OS, as
is.
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/238
Build and create tomcat, fix several other issues with management server
Hi guys,
This PR has the following goodies:
- Tomcat built by maven project (currently set to
47 matches
Mail list logo
