Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1299#issuecomment-172181534
Ping @remibergsma
LGTM, please proceed with merge.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1299#issuecomment-170097718
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1299
CLOUDSTACK-6485 prevent ip asignment of private gw iface
Prevent ipaddress asignment of gateway to gateway-interface on vpc router
by setting vpcid to null in network. This was fixed in
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1299#issuecomment-168196828
@remibergsma I looked it up but the commit is present in 4.7. Let's find
the breaking commit.
---
If your project is set up for it, you can reply to this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1299#issuecomment-168193893
Pinging @DaanHoogland remember this one? It's fixed in `4.4` but I hit it
again today in `4.7`.
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1299#issuecomment-168197900
LGTM, this is a regression from a code reformat in
a51690be4b07bea5208344b9b07a3d38fb0cbc60.
---
If your project is set up for it, you can reply to this
