Github user kwanggithub commented on the pull request:
https://github.com/apache/cloudstack/pull/151#issuecomment-93120538
Thanks to all who helped shepherd this effort! Happy to see this merged!
@karuturi , absolutely - I will fix the find bug issues, together with many
PMD
Hi kcwang,
Can you please take care of the findbugs issues?
you can run `mvn -P enablefindbugs -pl :cloud-plugin-network-bigswitch
verify` to see the list of issues.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+FindBugs
~Rajani
On Fri, Apr 10, 2015 at 9:51 PM, karuturi
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/151#issuecomment-91137623
With features like this, I am not sure what's best. Ideally we would pull
them in a separate feature branch and call a [MERGE] on the list. Then keep
track of it for
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/151#issuecomment-91136594
@runseb I can help merge it now, though I'll need to move the sql
statements to the other file. I guess since it's a small task I'll go ahead and
do it.
---
If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/151#issuecomment-91141081
@runseb I skimmed through the diff, since TravisCI is green and most major
changes are in the plugin itself I'm going ahead with the merge now.
---
If your project
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/151#issuecomment-91132416
@bhaisaab thanks for looking into this one. KC had several reviews in RB
and has been working on this for a while now. It's about time we try to merge
it.
---
If
GitHub user kwanggithub opened a pull request:
https://github.com/apache/cloudstack/pull/151
CLOUDSTACK-6697: bigswitch networking plugin update
1. provide compatibility with the Big Cloud Fabric (BCF) controller
L2 Connectivity Service in both VPC and non-VPC modes
2.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/151#issuecomment-91121751
Since I don't have any real hardware to test against and since TravisCI
build is green I'm merging it. Thanks @kwanggithub for the PR.
---
If your project is set
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/151#issuecomment-91122665
@kwanggithub sorry there are issues with the patch so I cannot merge it on
master;
1. the fix removes old apis and replaces them with new ones. This breaks
10 matches
Mail list logo
