Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122210319
Since the comment of @karuturi says there is something wrong with the code
I don't think we can say LGTM here?
I actually encountered this issue today on a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122216105
@wido, sounds like you mean to have it in but are not satisfied because of
@karuturi 's remark. I will look into adding the notify at some place as I
think it
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-15640
I found documentation on the net [1] that this is fine but I changed the
flow anyway
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122240171
I just tested it on 4.5 management server and my deployment errors are
gone. I'm fine with it.
LGTM
---
If your project is set up for it, you can reply to
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122241816
@DaanHoogland are you pushing this to 4.5 branch as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122246019
@karuturi @DaanHoogland @bhaisaab I suggest we merge it into 4.5 as well so
that it makes 4.5.2
---
If your project is set up for it, you can reply to this email and
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122234984
Its not always safe. http://stackoverflow.com/a/14837457/201514
In our example, the threads unnecessarily wait for 1000 ms if the previous
threads exited from a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122236249
figured something like that but had't noticed the wait :}
@bhaisaab @wido are you fine like with this?
---
If your project is set up for it, you can
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/572
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-122246365
will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/572#discussion_r34861726
--- Diff:
engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
---
@@ -216,15 +223,82 @@ public boolean
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/572#issuecomment-121829053
While LGTM and travis seems to be happy about it, my java kung - {locks and
synchroization} -fu skills are not to be trusted
---
If your project is set up for it,
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/572
CLOUDSTACK-7539: [S3] Parallel deployment makes reference count of a â¦
â¦cache in nfs secondary staging store negative(-1)
old review request by Hiroki Ohashi that is planned
13 matches
Mail list logo
