Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63441065
I dont see a case when it could return false then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/39
CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in
HypervInvestigator
Fixed wrong semantics for isVmAlive() method in HypervInvestigator
Findbugs will report error on
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63428603
From the method definition (isVmAlive), looks like what it is doing is
right.
ideally, we should change the return type from Boolean to boolean in the
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63429460
Actually null has different meaning than false. False means that vm is not
alive while null means it cannot be determined whether it is alive or not.
This
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63430873
In the second return statement, should it return false since the agent is
alive and returned some status?
I didnt understand the argument for not adding
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/39#issuecomment-63432886
No. Because agent is reporting status of host. We cannot determine the
status of VMs from that.
---
If your project is set up for it, you can reply to this email
