Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-121829664
LGTM, squashing and merging; please squash your changes in future as you
iterate on your PR
---
If your project is set up for it, you can reply to this email and h
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-121159832
In that case LGTM
Next time try to be more descriptive, since the Jira issue didn't show it
either. I really didn't know what you meant.
---
If your project i
You are right Wido. It is only a test case change to handle volume cleanup.
On Tue, Jul 14, 2015 at 11:43 AM, wido wrote:
> Github user wido commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/481#issuecomment-121140868
>
> The description of the pull request isn
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-121140868
The description of the pull request isn't really specific. Looking at the
files changed it is only a test case which changed, right? No CS code itself.
---
If your pro
Github user pritisarap12 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r33328911
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -115,32 +115,51 @@ def tearDownClass(cls):
raise Exception("W
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r33268358
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -115,32 +115,51 @@ def tearDownClass(cls):
raise Exception("
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-115109007
Delete volume was failing in cleanup before because volume was not in
detached state as snapshot creation failed and detach volume command did not
get executed
Github user gauravaradhye commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-113487609
Can you please explain why the test case was failing before? Why the
cleanup was failing for volume?
---
If your project is set up for it, you can reply to th
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/481#issuecomment-113485973
Removed reboot as it is not needed.
Below is the test result after removing reboot function:
Storage and Snapshot Limit ... === TestName:
test_01_st
Github user gauravaradhye commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/481#discussion_r32713393
--- Diff: test/integration/testpaths/testpath_snapshot_limits.py ---
@@ -341,4 +339,8 @@ def test_05_storage_snapshots_limits(self):
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/481
CLOUDSTACK-8556: Unable to delete attached volume in cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack de
12 matches
Mail list logo
