Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/546#issuecomment-118011859
@remibergsma and @karuturi
You are right.
I believe both @bhaisaab and I forgot that. Once he said go ahead with the
merge I just merged
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/546#issuecomment-118009819
@karuturi I agree, we should only proceed after two LGTMs.
Let met give the second LGTM, after the fact.
---
If your project is set up for it, you can reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/546#issuecomment-117653714
@wilderrodrigues LGTM, and Travis is green though there is no way for me to
test it against the real h/w. Please go ahead with the merge.
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/546#issuecomment-117896507
shouldnt we wait for another review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Hey guys,
Anyone willing to have a look at this PR?
Thanks in advance.
Cheers,
Wilder
Sent from my iPhone
On 30 Jun 2015, at 14:41, wilderrodrigues g...@git.apache.org wrote:
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/546