Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123661436
The https://builds.apache.org/job/cloudstack-pull-requests fail after
adding the Default Charset test. I think the localization of the Jenkins server
needs to be
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123609068
LGTM :+1: merging...
Thanks, @DaanHoogland !!!
Tested with:
KVM + Qemu on Centos7
Management Server on Centos7
Agent 4.6.0
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123579225
Keys are being created:
[root@kvm1 ~]# ls -lart ~/.ssh/
total 16
dr-xr-x---. 3 root root 4096 Jul 22 02:37 ..
drwx--. 2 root root 4096
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123571169
Will test it against KVM + Agent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123526216
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123471733
Hey @DaanHoogland
Just the initialiser stuff and the return of the getPreferredCharset()
method.
Cheers,
Wilder
---
If your project i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123460301
@wilderrodrigues of course, sure you want to wait for that?
And to what extend? we want tests for this initializer but also for the
agent and it's functionin
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/612#issuecomment-123387872
Hey @DaanHoogland
Could you write a test for that, please? :)
Cheers,
Wilder
---
If your project is set up for it, you can reply to th
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/612
CLOUDSTACK-8658: make initializer static instead of default
bad bug: ommision of the static keyword on initializer leaves data
uninitialized :{
You can merge this pull request into a Git r
10 matches
Mail list logo
