Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129407180
@DaanHoogland You already gave your LGTM? See here:
https://github.com/apache/cloudstack/pull/656#issuecomment-127529005
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129405117
@remibergsma ahum,... LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129396359
@koushik-das Thank you!
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129374324
@koushik-das Check, please squash and then force push again. After that
I'll merge it.
---
If your project is set up for it, you can reply to this email and hav
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129371706
@remibergsma Yes the commits can be squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129368352
@koushik-das Thanks, glad the merge commit is gone now. Do you want to keep
two commits? I'd say squash them together. From the subject line I cannot tell
the di
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129365283
Travis failure is due to timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129335984
@remibergsma I have fixed the commits, please check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129334661
@koushik-das Check. If you fix the commits, I'll LGTM and merge. Let me
know if you need help.
---
If your project is set up for it, you can reply to this email
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-129300344
@remibergsma Thanks for testing the PR. This is a best-effort fix. The
change just schedules the restart of the system VMs ahead of the user VMs. Now
if there ar
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128828795
Hi @koushik-das I was able to test your PR and it seems to do what you
said: start the system VMs before the other instances. However, it doesn't
solve the probl
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128748550
Thanks @miguelaferreira :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128748395
Hi @koushik-das
Sorry to step in like this, but I talked to @remibergsma and I think you
can fix your branch by doing this:
```
git checkout
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128745820
@remibergsma Will the following work?
- do git pull on master
- then do a git pull --rebase, this will make the commits appear on top
- then do the squ
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128727494
@koushik-das you can solve it like this:
- start with a new branch from your first commit
- then cherry-pick the second one in
- consider if you want t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128719973
@koushik-das I' testing this tonight and will merge if it's OK. Before I
proceed, could you please squash the 3 commits into 1. I cannot merge it like
this. Than
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128686334
@kishankavala Made the change to use VM type instead of name to distinguish
between user and system VMs
---
If your project is set up for it, you can reply to t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-128491021
@koushik-das Thanks for the fix! I was testing this on KVM tonight but run
into an unrelated issue. Will try to verify your fix tomorrow so we can merge
it soon.
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36382437
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -242,16 +242,19 @@ public void scheduleRestartForVmsOnHost(final HostVO
host
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36381969
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -242,16 +242,19 @@ public void scheduleRestartForVmsOnHost(final HostVO
hos
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36170828
--- Diff: server/test/com/cloud/ha/HighAvailabilityManagerImplTest.java ---
@@ -113,12 +110,18 @@
public void setup() throws IllegalArgumentEx
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36168376
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -261,25 +264,21 @@ public void scheduleRestartForVmsOnHost(final HostVO
host
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/656#issuecomment-127529005
code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36168074
--- Diff: server/test/com/cloud/ha/HighAvailabilityManagerImplTest.java ---
@@ -113,12 +110,18 @@
public void setup() throws IllegalArgumentE
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/656#discussion_r36167770
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -261,25 +264,21 @@ public void scheduleRestartForVmsOnHost(final HostVO
hos
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/656
CLOUDSTACK-8704: Schedule restart of router VMs ahead of user VMs as â¦
â¦part of HA
VRs are scheduled for HA ahead of user VMs.
Refer to the bug for more details.
You ca
27 matches
Mail list logo
