Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/713
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-213565364
I think this one is ready unless anyone has any final words...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r60792255
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-213407542
I need one more LGTM code review on this one. I will try to test this in
my lab today. Thanks...
---
If your project is set up for it, you can reply to this email
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-213278268
@bhaisaab rebased and merged into single commit ,@swill @koushik-das can
you please look into this
---
If your project is set up for it, you can reply to
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-191098254
sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-175665150
@nitt10prashant please rebase and meld into a single commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-141880475
The test Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-139975477
LGTM!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-132476722
test result of enough storage is not available to perform test
put storage in maintenance mode and start ha vm and check usage ... SKIP:
sufficient
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/713
CLOUDSTACK-8745 : verify usage after root disk migration
put storage in maintenance mode and start ha vm and check usage ... ===
TestName: test_ha_with_storage_maintenance | Status :
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379405
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379426
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379847
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379373
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379748
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379183
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379122
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379467
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379515
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37380762
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37380740
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user ksowmya commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37381494
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the Apache
23 matches
Mail list logo
