[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-139586066 I reverted the directed commit and merged this pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread nitt10prashant
Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-139530956 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-11 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-139582425 Hi @sanju1010 please use git-pr script to merge pull requests. Its in the source code at tools/git/git-pr Here is a doc on how to use it

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-04 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-137719672 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-09-01 Thread shwetaag
Github user shwetaag commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/728#discussion_r38500164 --- Diff: tools/marvin/marvin/config/test_data.py --- @@ -775,6 +775,15 @@ "ostype": "CentOS 5.6 (64-bit)" }, +

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-26 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/728#discussion_r37962558 --- Diff: tools/marvin/marvin/config/test_data.py --- @@ -775,6 +775,15 @@ ostype: CentOS 5.6 (64-bit) }, +

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/728#discussion_r37961562 --- Diff: tools/marvin/marvin/config/test_data.py --- @@ -775,6 +775,15 @@ ostype: CentOS 5.6 (64-bit) }, +

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-25 Thread shwetaag
Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-134504120 result information : @desc:Incorrect guest os mapping in vmware for CentOS 5.9 and above ... === TestName: test2_attach_ISO_in_CentOSVM | Status : SUCCESS

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-134706537 @shwetaag I have no VMware so cannot run this test. Is there any way to make the test more generic? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-23 Thread shwetaag
Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-134034345 @remibergsma the issue was of incorrect mapping of centos guest os (grater than 5.9 ) in cloud stack .CS was sending wrong info to Vcenter to launch VMs and

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-21 Thread shwetaag
GitHub user shwetaag opened a pull request: https://github.com/apache/cloudstack/pull/728 CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 5.9 Check the bug 8756 for more details You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...

2015-08-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/728#issuecomment-133548095 @shwetaag Please add more details on the actual problem (also in Jira) and what you want to achieve by adding this test. Both CentOS 5 and CCP 4.2.1seem very