[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134912770 Code LGTM (not tested on a real infra though), merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/729 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-25 Thread shwetaag
Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134502839 Result information: test_01_FTPModulesInVR (integration.component.maint.test_escalations_routers.TestVR) ... === TestName: test_01_FTPModulesInVR | Status :

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-25 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134706080 @shwetaag Thanks. I was also able to run your test. Please change the title, see previous comment. ``` [root@cs2 cloudstack]# cat

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134364759 @shwetaag Could you change the title to: CLOUDSTACK-8757: Test to verify if FTP modules are loaded in VR as right now it looks like there is a defect, which

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-23 Thread shwetaag
Github user shwetaag commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-134030869 @remibergsma : i have added details to the bug . Copy pasting for your reference To have Active FTP working in isolated networks VRs need the have the

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-21 Thread shwetaag
GitHub user shwetaag opened a pull request: https://github.com/apache/cloudstack/pull/729 CLOUDSTACK-8757:FTP modules are not loaded in VR check bug 8757 for more details . You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...

2015-08-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/729#issuecomment-133547422 @shwetaag Can you please add more details? The Jira issue only has a title. Are you submitting a test so in case the modules are not loaded, alarms go off? Or