Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1054
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-217010122
Done @rhtyd !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-216885592
@wido can you rebase for me? We apparently have merge conflicts now.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
repl
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-216204074
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-216203992
LGTM, let's merge if CI has passed; though we need to check installable
packages wrt all sort of scripts using it (like cloud-setup-databases and
others etc.)
---
I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215615196
CI has passed. The only issue we see is a connectivity issue I sometimes
see in my environment.
---
If your project is set up for it, you can reply to this email an
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215615124
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
```
**Summary of the problem(s):**
```
F
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215551291
Running CI now. Will have results later tonight or tomorrow...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215504839
I see this in the output when Marvin is installed.
```
Requirement already up-to-date: mysql-connector-python>=1.1.6
```
If I check the version I h
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215502330
@swill for the CI you can install using pip with: (this is also in
tools/travis/install.sh)
pip install --upgrade --egg
http://cdn.mysql.com/Downloads/Connector-P
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215472985
So are we happy with the state of this? How should I adjust my CI to
validate this fix?
I currently have:
```
yum -y install maven tomcat mkisofs
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215419241
@rhtyd I grepped *after* my modifications :)
Yes, the API between MySQLdb and mysql.connector is the same. The only
difference is the import and the connection
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215392929
@wido that is true, so will simply fixing the imports and usage work?
I found using `git grep MySQLdb`:
```
client/bindir/cloud-update-xenserver-licens
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-215391701
@swill @rhtyd: I looked through all the code and fixed it. Is was just two
more scripts.
wido@wido-desktop:~/repos/cloudstack$ grep -R "MySQLdb" *
wido@wid
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-213728252
Let's leave this open for now. I want to understand what is needed to fix
this project wide.
---
If your project is set up for it, you can reply to this email and h
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-213701028
Ok, leave this PR open or closed?
Keep in mind, the API of both packages is rather similar. Just the
connection creating is different. Atferwards it is getting
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-213413569
@wido I just want to verify that the standard CI run does not have any
issues. However, @bhaisaab does bring up some good points. We should try to
fix this everywhe
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-213331800
@wido we'll need to fix codebase wide mysqldb usage in python scripts and
build both rpms/deb to show installation, setting up of db and setting up mgmt
server wor
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-213298570
@swill I don't exactly know how to test this with CI. I verified it with
the test script I created.
Don't know how we can automate this in CI.
---
If your pr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-212981219
I need one more LGTM for this one and I would like to run CI to make sure
nothing breaks. Otherwise I think this is in a good place.
---
If your project is set up f
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-212789949
Can we already merge this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user wido reopened a pull request:
https://github.com/apache/cloudstack/pull/1054
CLOUDSTACK-8818: Use MySQL native connector with Python
MySQLdb has been deprecated and is also not supported in Python 3.
mysql.connector is a connector written in Python which talks th
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/1054
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-160930211
code lgtm but i have really no time to test this anytime soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-160648931
@borisroman @DaanHoogland Anybody else? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-158874821
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-156067993
@DaanHoogland Thanks! Now, that failure has nothing to do with this Python
code :)
---
If your project is set up for it, you can reply to this email and have your
rep
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-155456551
@wido
Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest
#
# A fatal error has been detected by the Java Runtime Environment:
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-155444641
"Apache CloudStack Server" has failed says Jenkins. I don't see a failed
test though?
---
If your project is set up for it, you can reply to this email and have your
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-155353598
Pylint result:
```
Global evaluation
-
Your code has been rated at 6.48/10 (previous run: 6.48/10, +0.00)
```
I also wr
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1054
CLOUDSTACK-8818: Use MySQL native connector with Python
MySQLdb has been deprecated and is also not supported in Python 3.
mysql.connector is a connector written in Python which talks the
31 matches
Mail list logo
