Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/795#issuecomment-139987172
@karuturi Fixed the findbug issue. Was due to reformatting of one method.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/795#discussion_r39372256
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
@@ -382,7 +424,7 @@ private String
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/795#issuecomment-139855167
@bhaisaab Will do! Please wait with merging, will commit them to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/795#issuecomment-139958818
Thanks @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/795#issuecomment-139493789
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/795#issuecomment-139524204
@borisroman looks good, can you increase code coverage by adding tests for
the utils and core changes?
---
If your project is set up for it, you can reply to this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/795#issuecomment-139523955
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/795#discussion_r39164669
--- Diff: utils/src/main/java/com/cloud/utils/storage/QCOW2Utils.java ---
@@ -0,0 +1,60 @@
+//
+// Licensed to the Apache Software Foundation (ASF)
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/795#discussion_r39168298
--- Diff: utils/src/main/java/com/cloud/utils/storage/QCOW2Utils.java ---
@@ -0,0 +1,60 @@
+//
+// Licensed to the Apache Software Foundation
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/795#issuecomment-139001500
Tested manually. Virtual size is correctly returned now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/795
CLOUDSTACK-8819: Added QCOW2 virtual size checking for S3.
- Cleaned up S3TemplateDownloader
- Created static QCOW2 utils class.
- Reformatted some parts of DownloadManagerImpl
You
12 matches
Mail list logo
