Github user sureshanaparti commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-140009394
@remibergsma That sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/806#discussion_r39372846
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -152,13 +152,26 @@ public void connect(String url, String
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-139962348
@remibergsma sure, but can do this next week (lack infra right now)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-139787067
@sureshanaparti Nice work! The PR title confused me a bit though. What
about:
CLOUDSTACK-8820: Support for VMware vCenter 6 data center
@bhaisaab
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/806
CLOUDSTACK-8820: Showing error when try to add vCenter 6
CLOUDSTACK-8820: Showing error when try to add advance zone using VMware
ESXi 6.0 host
Summary: In vCenter 6.0, response
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-139521285
Great PR @sureshanaparti I was going to work on supporting this as ESXi6
works well on top of KVM; I can test this for you next week; LGTM on code
change (not
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/806#discussion_r39265018
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -152,13 +152,26 @@ public void connect(String url, String
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/806#discussion_r39265110
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -577,41 +590,48 @@ public ManagedObjectReference
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/806#discussion_r39265179
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -577,41 +590,48 @@ public ManagedObjectReference
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-139532380
change makes sense but I have some comments on the coding style.
---
If your project is set up for it, you can reply to this email and have your
reply appear
10 matches
Mail list logo
