Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-140641828
Alright, let's wait for lab tests to confirm the patch and only then we
should merge it.
Thanks for helping test it @sateesh-chodapuneedi
---
If your
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-140644634
Tested adding ESXi 6.0 host to advanced ACS zone successfully.
Session logic is working fine.
@bhaisaab you might want to go ahead merge
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/806
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-140627846
@sureshanaparti code LGTM.
I will test this patch today in my lab and will get back.
---
If your project is set up for it, you can reply to this
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/806#issuecomment-140056577
FWIW LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/806#discussion_r39377834
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -577,41 +590,48 @@ public ManagedObjectReference
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/806#discussion_r39378030
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java ---
@@ -577,41 +590,48 @@ public ManagedObjectReference
