[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/803#issuecomment-216189015 @anshul1886 please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/803#issuecomment-175666319 @anshul1886 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2015-09-13 Thread anshul1886
Github user anshul1886 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/803#discussion_r39361975 --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java --- @@ -350,4 +351,20 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2015-09-11 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/803#issuecomment-139521700 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8833: Fixed Generating url and...

2015-09-11 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/803#discussion_r39266451 --- Diff: engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java --- @@ -350,4 +351,20 @@ public void