Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/808#issuecomment-139957981
@DaanHoogland the repeated code is two lines calling sendalert and logger.
may be we could move the logging to send alert itself. Will check that later.
---
If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/808#issuecomment-139521444
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/808
CLOUDSTACK-8835: Added alerts incase of template download failure
Authored-By: @sanjaytripathi
Reviewed-By: Devdeep
You can merge this pull request into a Git repository by running:
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/808#issuecomment-139532776
Makes sense and LGTM. I see some code duplication in
ImageStoreUploadMonitorImpl, though. A good moment to get rid of this?
---
If your project is set up for
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/808#issuecomment-139538657
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
