[GitHub] cloudstack pull request: CLOUDSTACK-8838 Interface pattern check

2015-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/973 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8838 Interface pattern check

2015-10-25 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150953447 @remibergsma @DaanHoogland LGTM :+1: Thanks for adjusting the unit test. ``` Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResour

[GitHub] cloudstack pull request: CLOUDSTACK-8838 Interface pattern check

2015-10-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150785113 @DaanHoogland No, just the PR title. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cloudstack pull request: CLOUDSTACK-8838 Interface pattern check

2015-10-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150783777 @remibergsma title prefix added to the PR, would you wnat it on the commit as well? --- If your project is set up for it, you can reply to this email and have