Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/840
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/840#issuecomment-162229695
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_v
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/840#issuecomment-152974654
@bhaisaab
fixed the double indent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/840#issuecomment-141343287
LGTM, pl fix one of the indentation issues and perhaps use better and
verbose log messages.
---
If your project is set up for it, you can reply to this email and h
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/840#discussion_r39823849
--- Diff:
framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java
---
@@ -96,12 +96,13 @@ publi
GitHub user bvbharatk opened a pull request:
https://github.com/apache/cloudstack/pull/840
CLOUDSTACK-8852 Database shows that management server is UP when it iâ¦
â¦s actually stopped from the CCP GUI
This was happening as the stop method in clusterMnanagerImpl was not
