Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/923
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147841813
@remibergsma @karuturi @wilderrodrigues @DaanHoogland I tested this PR
today. Tests ran fine except for the cleanups (which are known by
CLOUDSTACK-8935). I'll sp
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147780057
Let's wait for the test results of @borisroman as he said he was testing as
well.
@borisroman if you are no longer testing, please let us know.
---
If your
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147749011
thanks for running the tests @remibergsma
should we merge this PR since we have two reviews from @DaanHoogland and
@remibergsma ?
---
If your project is set u
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147700296
@wilderrodrigues Thanks, looking good! LGTM
Tested on 2-node KVM cluster on CentOS 7.
I started by running the same tests:
```
nosetests
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147633618
Testing now, will post results later today!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147342723
@wilderrodrigues I will spend some time on testing this today!
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/923#discussion_r41730481
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -123,24 +129,29 @@ def add_rule(self, cidr):
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147205805
overall code looks good, not sure if I need to test something special,
@wilderrodrigues
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/923#discussion_r41711315
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -123,24 +129,29 @@ def add_rule(self, cidr):
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/923#issuecomment-147191452
Ping @remibergsma @karuturi @DaanHoogland @miguelaferreira @bvbharat @wido
@borisroman
All, the tests were executed successfully! We still have the
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/923
CLOUDSTACK-8934 - Default routes not configured for rVPC and RVR
This PR fixes the default routes for redundant VPCs and isolated networks.
New tests were introduced in order to make sur
12 matches
Mail list logo
