Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46774983
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162332724
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46773579
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46769041
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46767279
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162231372
@anshul1886 Please address comments made above. After that we can merge.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162231182
Run the tests again and it looks good.
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advan
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162050985
FYI, this integration test failed:
```
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_V
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162030592
LGTM, but just fix the .equals()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46707102
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162027142
@anshul1886 thanks a lot!
now I agree with you that we should revert 66fed46.
this PR LTGM, just one small comment.
I will create another PR for
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-161931232
@ustcweizhou I differ on this. We should not make HypervisorGuruManagerImpl
complex by adding these kind of conditions as nobody is expert of all
hypervisors and
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-161929602
@anshul1886 thanks for pointing out.
I think it is not reasonable to send command to each hypervisorguru, so my
suggestion is to not change HypervisorGuruM
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-161927620
@ustcweizhou That bug is already taken care in Ovm3 guru code with commit
66fed46
---
If your project is set up for it, you can reply to this email and have you
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-161926055
@anshul1886 I do not have Xenserver, so I do not test it.
However, I have to say that the issue CLOUDSTACK-8964 will appear again
with this commit.
---
If
Github user anshul1886 closed the pull request at:
https://github.com/apache/cloudstack/pull/1174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1176
CLOUDSTACK-9025: Fixed can't create usable template from snapshot in
Xenserver and Vmware
https://issues.apache.org/jira/browse/CLOUDSTACK-9025
Fix also reverts below commit as belo
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1174
CLOUDSTACK-9025: Fixed can't create usable template from snapshot in
Xenserver and Vmware
https://issues.apache.org/jira/browse/CLOUDSTACK-9025
Fix also reverts below commit as belo
19 matches
Mail list logo
