Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-155115419
OK, now these became a textual change in Python. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44280237
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/clo
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44275343
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloud
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44275233
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloud
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44274922
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/clou
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44271548
--- Diff: python/lib/cloudutils/serviceConfig.py ---
@@ -54,7 +54,7 @@ def configration(self):
except:
logging.debug(fo
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44271484
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/clo
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44271177
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,7 @@ def checkHostName():
bash("chown cloud.cloud /var/run/clou
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44270972
--- Diff: python/lib/cloudutils/serviceConfig.py ---
@@ -54,7 +54,7 @@ def configration(self):
except:
logging.debug(for
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-155053983
@wido @ustcweizhou Can you look again here please, see @borisroman's
comments.
---
If your project is set up for it, you can reply to this email and have your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44210798
--- Diff: python/lib/cloudutils/serviceConfig.py ---
@@ -54,7 +54,7 @@ def configration(self):
except:
logging.debug(fo
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154411673
@wido @ustcweizhou Could you review again please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154409103
@remibergsma @ustcweizhou As @wido pointed out, they are already created
through the packager.
https://github.com/apache/cloudstack/blob/master/debian/ru
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154405523
FYI: Started tests on this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44132316
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cloudstack-
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154350435
@borisroman LGTM if remove line 110.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44116130
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/clou
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1039#issuecomment-154343137
@ustcweizhou This is only for the management server! The usage server will
create it's own paths when installed. @milamberspace I'll push that change,
thanks!
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44112930
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/clou
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1039#discussion_r44112143
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -107,7 +107,8 @@ def checkHostName():
bash("chown cloud.cloud /var/run/cl
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1039
CLOUDSTACK-9039: Fix paths for logging Ubuntu Management
Fix paths for logging Ubuntu Management.
How to test:
Install via DEB packages...
You can merge this pull request into a
22 matches
Mail list logo
