Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-162335446
two lgtm, no response to the the answers on reviews so merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1086
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-162053643
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-161226000
@ustcweizhou @DaanHoogland
I was on holidays last week... just got back to the PR-Pool. I saw that
@DaanHoogland already tested, so I will do a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-160134110
@wilderrodrigues @jayapalu @koushik-das Are you guys satisfied with this
patch?
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-159391187
tests performed
[1086.network.results.txt](https://github.com/apache/cloudstack/files/43165/1086.network.results.txt)
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-159211074
Just added a new commit in this PR.
CLOUDSTACK-9051: reprogram network as a part of vm nic ip update
Review and testing are welcome!
---
If your
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158360198
@jayapalu
1.
The /etc/dhcphosts.txt will not be changed inside VR during this process.
root@r-7542-VM:~# cat /etc/dhcphosts.txt
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158346095
@ustcweizhou Some questions.
1. Is updateVmNicIp API admin only?
2. How the caller knows if the IP address is available and what is the CIDR
associated
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158353414
@jayapalu this discussion is mirrored on dev@ so it is a discussion on the
mailing list. In that sense the process reqs are met. Also @wilderrodrigues
already
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158351915
@ustcweizhou @wilderrodrigues @koushik-das
It is an enhancement/feature to the product. Also a new API is introduced
here.
So I would recommend to go
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158358371
@koushik-das answers:
1. not only admin , but domain admin and normal user
2. for isolated network, the user can get the information (ip, cidr)
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158012460
@wilderrodrigues
I added some unit tests.
you can test it via api:
command=updateVmNicIp=json=92ad2e8b-f8d8-4aec-a975-16ee1e4ef0fe=10.1.43.20
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1086
CLOUDSTACK-9051: update nic IP address of stopped vm
This provides the feature to change ip address of NIC on a stopped vm by
API and UI.
You can merge this pull request into a Git
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-157647040
And how are we suppose to help reviewing/testing this PR, @ustcweizhou ?
Any time to add some unit/integration tests and write few steps so we can
15 matches
Mail list logo
