Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1130#issuecomment-185610104
Testcase result after modifications:
Test Volume (root) Snapshot ... === TestName: test_01_volume_snapshot |
Status : SUCCESS ===
ok
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1130#issuecomment-175683955
@sanju1010 looking forward to the test results
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1130#issuecomment-167562545
This is one line change and looks good. I will get test results for this.
LGTM!!
---
If your project is set up for it, you can reply to this email and have
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/1130#issuecomment-166878921
@remibergsma can you please merge this in? Thanks, Raja
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1130#issuecomment-166879268
@pvr9711 Please make sure we have 2xLGTM of which at least one run the
test. Will not merge without.
---
If your project is set up for it, you can reply to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1130#issuecomment-160908545
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/1130
CLOUDSTACK-9091: Update testpath for parameter issues
In testpath_volume_snapshot testpath creating volume from snapshot function
is passing zonid parameter to function in base class but
