Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162624037
agree with @bhaisaab , @nlivens this will certainly decrease the failure
rate ;)
---
If your project is set up for it, you can reply to this email and have yo
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162549079
@nlivens I like your patch, can you send that as a separate PR please?
LGTM, cc @remibergsma please merge this (do you need to run your tests, if
necessary?)
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162523432
@DaanHoogland, below you can find a possible alternative for this test file.
[HypervisorUtilsTestPatch.txt](https://github.com/apache/cloudstack/files/53965/Hype
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162498348
@nlivens there are several tests like this bugging us. Do you know an
alternative for this one?
---
If your project is set up for it, you can reply to this em
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162496553
@bhaisaab, we've looked into the code of that test, and the results are
unreliable.
The steps that are done in that test (along with the implementation of the
c
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162493847
@remibergsma Do you remember any changes that might be causing
HypervisorUtilsTest.checkVolumeFileForActivityTest to fail?
---
If your project is set up for it, y
Github user fmaximus commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162483085
Are we still taking Travis into account? It has a unit test failure in
HypervisorUtilTest, which also failed in other builds on Travis. This test
seems to fail ran
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162464159
s/4.6/master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162464119
@nlivens cool, LGTM. Will merge on 4.6 once the build checks complete.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162462731
@jburwell, thanks for the review! I've handled your comments. Thanks
@bhaisaab, would be great if we can still get this in 4.7
---
If your project is set up for it
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162416088
@nlivens Nick, while it LGTM if you can resolve some of the code issues
John can mentioned today, I can help review and merge this today before
4.7.0/master freeze
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1142#issuecomment-162054305
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1142#discussion_r46650221
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1276,6 +1277,53 @@ public String toString() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1142#discussion_r46650119
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -1276,6 +1277,53 @@ public String toString() {
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1142
CLOUDSTACK-9095 : Hypervisor changes to support UserData for Nuage VSP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack m
16 matches
Mail list logo
