Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60565861
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-212873785
@priyankparihar we'll need a unit test that shows that this change is
backward compatible. I like that we're considering both default instance name
with host name
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562805
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562370
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562268
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60562111
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60561870
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user sateesh-chodapuneedi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60561591
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60372700
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r53554647
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int
Github user priyankparihar commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-179028659
Hi,
@alexandrelimassantana thanks for notifying. I have made modification,
according to your suggestion.
---
If your project is set up for it, you
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-174396396
@priyankparihar, since you are modifying this method, you could also
generate it's javadoc. It would be a nice upgrade from that single line comment
Github user priyankparihar commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49171092
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49183061
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r49103580
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2032,11 +2032,20 @@ int
Github user priyankparihar closed the pull request at:
https://github.com/apache/cloudstack/pull/1165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1302
CLOUDSTACK-9104: VM naming convention in case vmware is used
I have reverted all the changes. Now functionality is same as it was in
earlier version.
ACS Bug Link is as follow ==>
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-162341273
@priyankparihar I do not know any vmware users
@bhaisaab Do you have any insight on this change? or do you know any
candidate reviewer for this?
---
If
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1165#discussion_r46787171
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1889,11 +1889,20 @@ int
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1165#issuecomment-162413895
@DaanHoogland yes I can do that, I'm personally dealt with a lot of
vmware/cloudstack naming issues. The syntax/pattern has changes several times
in the past
GitHub user priyankparihar opened a pull request:
https://github.com/apache/cloudstack/pull/1165
CLOUDSTACK-9104: VM naming convention in case vmware is used
I have reverted all the changes. Now functionality is same as it was in
earlier version.
You can merge this pull request
21 matches
Mail list logo
