Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1201#issuecomment-163583068
... slightly late, LGTM (did code review)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1201
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1201#issuecomment-163579051
Had a look at the code and trusting @remibergsma his test work: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1201#issuecomment-163578041
Integration tests are also OK:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1201#issuecomment-163562169
LGTM, both users and admins can login with/without this plugin enabled.
User login with plugin disabled:
