[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-173185402 Conflicts, won't resolve them. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164272079 @bhaisaab Yes! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164272026 @borisroman alright, so we review/merge the other PR first and then come to this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164271411 Hi @bhaisaab, True, that you see 2 commits! Due to the fact that this PR depends heavily on #1224. The commit id of the first commit is the same as the o

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164271090 @borisroman do you need to remove one of the commits around moving to default maven project structure? I see two commits. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-12 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164175379 @remibergsma Please try again! I changed a few files today. You probably didn't notice because I squashed them in the commit from yesterday. (Which you likely bu

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164174234 @borisroman I can't get it to run. It builds but after start it errors out like this: ``` 2015-12-12 10:01:33,843 WARN [o.a.c.s.m.c.ResourceApplica

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-12 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164163506 It works! Though please tests yourself for more confidence! @wilderrodrigues @miguelaferreira @remibergsma **Environment** - 1 KVM host on CentOS 7.

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164134517 The build still works indeed, bu I'd love to see if all the tests still work. We transfer TOs between the Agent and Mgmt server and they contain full package