Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-221834704
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-221764160
Need code review on this one. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220628965
Similar issues on this run. They are not related to this PR. Still need
some review on this one...
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220628656
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 4
Duration: 8h 31m 38s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220627549
Thanks @koushik-das, I need to track down what changed to cause that
intermittent problem of the `template.status`. I need some code review on this
one. Thanks...
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220558485
@swill The failures are not related to this PR.
The failure in test_internal_lb.py is due to some cleanup issue. The
network deletion failed most probably
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220512305
I don't think these issues are related to this PR, but if you have any
insight as to why they might be happening I would be interested. I will run
this CI again to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-220512147
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 1
Errors: 4
Duration: 9h 31m 01s
```
**Summary of the
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/1251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-216208899
@koushik-das can you rebase against latest master and share state of your
PR, thanks
---
If your project is set up for it, you can reply to this email and have your
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-209922105
### ACS CI BVT Run
**Sumarry:**
Build Number 175
Hypervisor xenserver
NetworkType Advanced
Passed=34
Failed=21
Skipped=2
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-199189395
@bvbharat Can you run the tests on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-173195505
Ping @remibergsma
This one ca have the integrations tests executed against.
@pedro-martins: no need to add javadocs. The code should be
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-173220018
@wilderrodrigues Agreed @pedro-martins comments, persé should add to the
clarity of the code, even javadoc. If the name is explanatory and there are no
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-170488605
@pedro-martins By java doc are you referring to adding some comments for
isRouterDeployed()? Note that this is a private method.
If you look at the unit
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-170636370
A javadoc is a notation above the method declaration that describes what
the method do.
javadoc with examples :)
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-170406819
nice =)
Can you create a java doc to explain your 'isRouterDeployed()' (even the
name explaining itself)?
If you can create a test case for only
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1251
CLOUDSTACK-9180: Optimize concurrent VM deployment operation on same â¦
â¦network
Check if VR needs to be allocated for a given network and only acquire lock
if required
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-165092578
Simulator test results for basic zone. Failure is for NiciraNvp which can
be ignored.
20 matches
Mail list logo
