[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

2016-01-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1298#issuecomment-172181476 Ping @remibergsma LGTM, please proceed with merge. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

2016-01-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

2016-01-08 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1298#issuecomment-170098587 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

2016-01-05 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1298#issuecomment-169132861 Trivial fix indeed. We can ignore this since our goal has been reached. LGTM --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9204 Do not error when staticr...

2015-12-31 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1298 CLOUDSTACK-9204 Do not error when staticroute is already gone When deleting a static route fails because it isn't there any morei (KeyError), it should succeed instead. Error