Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1318#issuecomment-172181655
Sat together with @borisroman when he was working on it. LGTM
Ping @remibergsma
Please proceed with merge.
Cheers,
Wilder
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1318#issuecomment-170355370
I am in favour of simplification. one question: doesn't this fire much more
release commands then needed? one for every interface on the router, while it
is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1318#issuecomment-170097321
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1318
CLOUDSTACK-9216: Fix DHCP lease removal logic on VR
It now releases all DHCP leases when requested.
Will post Integration test results once finished.
You can merge this pull
