[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-05-26 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-222045623 ### ACS CI BVT Run **Sumarry:** Build Number 61 Hypervisor xenserver NetworkType Advanced Passed=66 Failed=2 Skipped=3 _

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-05-12 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-218959269 LGTM @nitin-maharana can you comment on Koushik's remark and also share screenshot --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-216220849 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-04-25 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-214306315 @koushik-das : I will check it. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-04-25 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-214204041 @nitin-maharana The second dialog is not going away after clicking "yes" even though the API call is issued with forced=true. I don't think this is expected. It

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-04-21 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-212799750 @koushik-das: Actually this dialog appears after the first CIDR unchanged confirmation dialog. If its an admin account, Even if we select yes/no, it will be

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-04-19 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-21190 @nitin-maharana Looks like there is some problem. In confirmation dialog when I click "yes" nothing happens and on clicking "no" the offering is changed. ---

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-03-24 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-201016129 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 ### ACS CI BVT Run **Sumarry:**

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-175690879 LGTM, has anyone tested this other than the author? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-01-25 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-174578490 @rafaelweingartner : Yes, it will be forward merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-01-25 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-174442821 @nitin-maharana, it is much better now (did you see the difference?). I would just recommend you declaring a function as “var functionName = function

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-01-24 Thread nitin-maharana
Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-174411698 Hi @rafaelweingartner , I have updated the required change. Please have a look. Thank you. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-01-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1333#issuecomment-174176375 Hi @nitin-maharana , The lines from 970-1040 and lines from 1048-1118 are the same code. Would you mind extracting them to a function? Then you co

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

2016-01-13 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1333 CLOUDSTACK-9228: Network update with mistmatch in services require forced option Steps to reproduce: === 1.Bring up CloudStack in advanced zone 2.Create isolated