[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-173194446 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-18 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1349 CLOUDSTACK-9239 throw exception on deprecated command an API call to LockAccount fails silently with a 200 return and no contents. client are responsible to check and will find that no

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-18 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172603168 Shouldn’t we make that clear at the documentation too? I mean, the method/function should contain some info about the removal of the function. It is

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172606992 Makes sense Rafael, added something to that regard --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-18 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172619972 Giving that, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-18 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172622057 @DaanHoogland Please check, it doesn't compile :-( ``` [ERROR] COMPILATION ERROR : [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-9239 throw exception on deprec...

2016-01-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1349#issuecomment-172657149 f(^(* cherry-pick problem. it was fixed in 4.2.1 first :( --- If your project is set up for it, you can reply to this email and have your reply appear on