[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

2016-02-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1383#issuecomment-179703106 Test results, tested together with #1386: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

2016-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

2016-02-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1383#issuecomment-178167084 LGTM based on the code. any test for this available? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

2016-02-01 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1383#issuecomment-178064659 LGTM :+1: Based on codereview Already running in PROD at SBP. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

2016-01-29 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1383 CLOUDSTACK-9264: Make /32 static routes for private gw work Static routes for private gateways that were /32 failed because the `route` command used had `-net` in it and a `/32` requires

[GitHub] cloudstack pull request: CLOUDSTACK-9264: Make /32 static routes f...

2016-01-29 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1383#issuecomment-176950230 Tested the following static routes: https://cloud.githubusercontent.com/assets/1630096/12686942/1f0c9a3c-c6cd-11e5-9b65-60e813fdde47.png;> Both show