Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218544251
It was stuck due to another jenkins job running. I am still not sure I saw
what I saw. when I stopped 1252, shortly after 1253 through 1256 finished.
---
If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218505040
@DaanHoogland it finished!!! :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218467871
@swill I closed and reopened. It started building anew but is now stuck in
the archiving phase for quite some time.
```
[INFO]
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1385
CLOUDSTACK-9265 cleanup around httpclient versions
some cleanup done
- replaced HttpStatus from org.apache.commons.httpclient with that from
org.apache.http
- removed unthrown
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1385
CLOUDSTACK-9265 cleanup around httpclient versions
some cleanup done
- replaced HttpStatus from org.apache.commons.httpclient with that from
org.apache.http
- removed unthrown
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1385
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-218366133
@DaanHoogland can you force push this one again so we can kick off Jenkins
again. It has been stuck in this state for a week. Thx...
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-217471764
Can you do a force push again. Jenkins has been in this state for 3 days
now. Thx...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-216321608
@rafaelweingartner thanks. I understand completely...
I know the `final` stuff is debatable, but I don't think that should block
a PR. :)
I think
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-216319655
Hi @swill no problem, you might be calling me on other PRs, and I might
have not answered you. Sadly, duty is calling these days, few papers were
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-216296327
Missing one code review on this one. @rafaelweingartner? I saw you post
in this thread, so I am calling you out. :P
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-21610
@DaanHoogland rebase against latest master thanks
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-197459214
### ACS CI BVT Run
**Sumarry:**
Build Number 103
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=16
Skipped=4
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-184183368
catch Throwable is really evil, I agree. :(
At least the catch Exception of BrocadeVcsApi is re-thrown.
---
If your project is set up for it, you can
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-184182546
No problem Daan, I understand.
I was referring to the try-catches at lines 58, 65 and 140 of
âClusterServiceServletHttpHandlerâ; and at line 472
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-184178201
@rafaelweingartner very fine but really out of scope now. Can you be more
specific? I suspect these are in code where an automatic 'final' policy was
applied.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-184008194
Hi Daan,
Since you are cleaning things up, what about changing those âpokemonsâ
try-catches for specific ones?
---
If your project is set up
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-178702561
LGTM (just did code review, no regression tests)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1385
CLOUDSTACK-9265 cleanup around httpclient versions
some cleanup done
- replaced HttpStatus from org.apache.commons.httpclient with that from
org.apache.http
- removed unthrown
21 matches
Mail list logo
