[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218544251 It was stuck due to another jenkins job running. I am still not sure I saw what I saw. when I stopped 1252, shortly after 1253 through 1256 finished. --- If y

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218505040 @DaanHoogland it finished!!! :P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-11 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218467871 @swill I closed and reopened. It started building anew but is now stuck in the archiving phase for quite some time. ``` [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-11 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1385 CLOUDSTACK-9265 cleanup around httpclient versions some cleanup done - replaced HttpStatus from org.apache.commons.httpclient with that from org.apache.http - removed unthrown Ht

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-10 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-10 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1385 CLOUDSTACK-9265 cleanup around httpclient versions some cleanup done - replaced HttpStatus from org.apache.commons.httpclient with that from org.apache.http - removed unthrown Ht

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-10 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-10 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218366133 @DaanHoogland can you force push this one again so we can kick off Jenkins again. It has been stuck in this state for a week. Thx... --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-06 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-217471764 Can you do a force push again. Jenkins has been in this state for 3 days now. Thx... --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-02 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216321608 @rafaelweingartner thanks. I understand completely... I know the `final` stuff is debatable, but I don't think that should block a PR. :) I think t

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-02 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216319655 Hi @swill no problem, you might be calling me on other PRs, and I might have not answered you. Sadly, duty is calling these days, few papers were accepted

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-02 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216296327 Missing one code review on this one. @rafaelweingartner? I saw you post in this thread, so I am calling you out. :P --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-21610 @DaanHoogland rebase against latest master thanks tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-03-19 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-197459214 ### ACS CI BVT Run **Sumarry:** Build Number 103 Hypervisor xenserver NetworkType Advanced Passed=103 Failed=16 Skipped=4

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-02-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-184183368 catch Throwable is really evil, I agree. :( At least the catch Exception of BrocadeVcsApi is re-thrown. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-02-15 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-184182546 No problem Daan, I understand. I was referring to the try-catches at lines 58, 65 and 140 of “ClusterServiceServletHttpHandler”; and at line 472 of

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-02-15 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-184178201 @rafaelweingartner very fine but really out of scope now. Can you be more specific? I suspect these are in code where an automatic 'final' policy was applied.

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-02-14 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-184008194 Hi Daan, Since you are cleaning things up, what about changing those “pokemons” try-catches for specific ones? --- If your project is set up fo

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-02-02 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-178702561 LGTM (just did code review, no regression tests) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

2016-01-29 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1385 CLOUDSTACK-9265 cleanup around httpclient versions some cleanup done - replaced HttpStatus from org.apache.commons.httpclient with that from org.apache.http - removed unthrown Http