[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

2016-02-04 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1386#issuecomment-179703172 Test results, tested together with #1383: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

2016-02-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

2016-02-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1386#issuecomment-178165074 makes sense looks good, was it put in production without test? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

2016-02-01 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1386#issuecomment-178064345 LGTM :+1: Already running in PROD at SBP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9266: Make deleting static rou...

2016-01-29 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1386 CLOUDSTACK-9266: Make deleting static routes in private gw work The to-be-deleted static routes were removed from the json file, instead of putting them there with revoke=true. The script